Punishment

Despite the fact that punishment rarely accomplishes the changes in behavior one desired, some people retain an unrelenting belief in its effectiveness. Many pets are traumatized and ultimately ruined by failed rituals of punishment, retribution and reprisal. Before considering punishment to change your pet's behavior, ask, "Is it safe?" After punishing your pet, ask, "Did it work?"

If you are constantly punishing your dog for urinating on the carpet then the punishment isn't working.
Stop thinking about what you don't like about your dog: I don't want him urinating on my carpet.
Think about what your want your dog to do: I want my dog to urinate on the curb outside on our walks.
Then work towards training a positive bathroom break. Train happy to go on leash. Train happy to pee in front of you. Train urinating outside. Then train urinating only near the curb. Then train only urinating on the curb at the end of your block.

If you work in this manner of little positive steps over a couple months you will have that dogs that can "hold it for hours on end" and always goes on the curb right at the beginning of the walk.

How wonderful